Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQNET-630: Update .NET Core version to 3.0 and C# to 8.0 #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Havret
Copy link
Contributor

@Havret Havret commented Nov 22, 2019

No description provided.

@@ -1,7 +1,7 @@
language: csharp
solution: apache-nms-amqp.sln
mono: none
dotnet: 2.2.401
dotnet: 3.0.101
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely 3.0 can run 2.0 libs? This would remove capability from those on 2.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always ensure back compatibility

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g can we make 3.0 additive , keeping existing 2.2 that way if ever a break it would be found

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelandrepearce I will try to do it. But currently we have other problems. For instance that update to .net core 3.0 breaks quite of few of our tests on linux env. I will look at it, but have to set up a linux box once again to do so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Havret whats latest with this PR?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this PR going to be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants